Silence ENOENT errors and sync networks if no match is found #85
Conversation
The files has been removed there is no need to log a error we can simply ignore it. Signed-off-by: Paul Holzinger <[email protected]>
In the podman CI tests are consistently flaking with CNI network not found ... I think the problem is that ocicni updates based on fsnotify and this can be slower than the podman calls. As a solution the networks should be synced if no match is found. If it is still not found afterwards return the network not found error. Signed-off-by: Paul Holzinger <[email protected]>
openshift-ci-robot
added
dco-signoff: yes
|
@baude PTAL. This will fix the remote integration test network flakes. |
|
This does not only happens in the podman CI other users are able to reproduce, see containers/podman#9451 (comment) |
openshift-ci-robot
added
release-note
|
/lgtm |
|
@jwhonce: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
rhatdan
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: Luap99, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Do not print ENOENT errors when loading networks
The files has been removed there is no need to log a error
we can simply ignore it.
Reload networks if none is found
In the podman CI tests are consistently flaking with CNI network not
found ... I think the problem is that ocicni updates based on fsnotify
and this can be slower than the podman calls.
As a solution the networks should be synced if no match is found. If
it is still not found afterwards return the network not found error.
I tested this in the podman containers/podman#9449 and I didn't saw the described flakes in the remote integration tests.